Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix of contract modifications and tests #592

Merged
merged 19 commits into from
May 2, 2023

Conversation

martinkersner
Copy link
Member

@martinkersner martinkersner commented May 1, 2023

Description

Contract-related changes

  • New parameter (address refundRecipient) when requesting for service with temporary account
  • Move payment in Request-Response service after cleanupAfterFulfillment (return list of oracles that should be paid)
  • estimateFee made public so consumers can know how much $KLAY to send before requesting for service

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

@martinkersner martinkersner self-assigned this May 1, 2023
@martinkersner martinkersner changed the title Aggregator modifications and tests Mix of contract modifications and tests May 2, 2023
@martinkersner martinkersner marked this pull request as ready for review May 2, 2023 01:02
@martinkersner martinkersner requested review from a team and bayram98 as code owners May 2, 2023 01:02
@martinkersner martinkersner merged commit dab09dd into master May 2, 2023
@martinkersner martinkersner deleted the i-591/feat/aggregator-modifications-and-tests branch May 2, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant