Skip to content

Commit

Permalink
Do not use dependency analyze when compiling plugins
Browse files Browse the repository at this point in the history
It is not correctly getting skipped.
  • Loading branch information
jduo committed Nov 26, 2023
1 parent aecee88 commit c4d0465
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 44 deletions.
22 changes: 0 additions & 22 deletions java/maven/module-info-compiler-maven-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -101,28 +101,6 @@
</plugins>
</pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>analyze</id>
<phase>verify</phase>
<goals>
<goal>analyze-only</goal>
</goals>
<configuration>
<!--
The dependency on org.glavo.module-info-compile is incorrectly
being reported as unused when running the Windows 2022 CI agent only.
Ignoring this dependency specifically is not happening on that agent either
so skip the plugin entirely.
-->
<skip>true</skip>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
Expand Down
22 changes: 0 additions & 22 deletions java/maven/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -268,28 +268,6 @@
<linkXRef>false</linkXRef>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>analyze</id>
<phase>verify</phase>
<goals>
<goal>analyze-only</goal>
</goals>
<configuration>
<ignoreNonCompile>true</ignoreNonCompile>
<failOnWarning>true</failOnWarning>
<ignoredDependencies>
<!-- source annotations (not kept in compiled code) -->
<ignoredDependency>javax.annotation:javax.annotation-api:*</ignoredDependency>
<ignoredDependency>org.apache.hadoop:hadoop-client-api</ignoredDependency>
</ignoredDependencies>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.cyclonedx</groupId>
<artifactId>cyclonedx-maven-plugin</artifactId>
Expand Down

0 comments on commit c4d0465

Please sign in to comment.