Skip to content

Commit

Permalink
Skip the maven-dependency-plugin analyze check due to false positive
Browse files Browse the repository at this point in the history
Reports a used dependency as unused only on Windows 2022 CI runs
  • Loading branch information
jduo committed Nov 26, 2023
1 parent f4fc26e commit c67a59b
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 1 deletion.
23 changes: 22 additions & 1 deletion java/maven/module-info-compiler-maven-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
<groupId>org.glavo</groupId>
<artifactId>module-info-compiler</artifactId>
<version>2.0</version>
<type>jar</type>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
Expand Down Expand Up @@ -103,6 +102,28 @@
</plugins>
</pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>analyze</id>
<phase>verify</phase>
<goals>
<goal>analyze-only</goal>
</goals>
<configuration>
<!--
The dependency on org.glavo.module-info-compile is incorrectly
being reported as unused when running the Windows 2022 CI agent only.
Ignoring this dependency specifically is not happening on that agent either
so skip the plugin entirely.
-->
<skip>true</skip>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugin-plugin</artifactId>
Expand Down
1 change: 1 addition & 0 deletions java/maven/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<encoding>UTF-8</encoding>
<source>1.8</source>
<target>1.8</target>
<maxmem>2048m</maxmem>
Expand Down

0 comments on commit c67a59b

Please sign in to comment.