Integrate abstractions projects into client build. #41
Conversation
MaxKsyunz
requested review from
Yury-Fridlyand
and removed request for
Yury-Fridlyand
| <SignAssembly>true</SignAssembly> | ||
| <AssemblyOriginatorKeyFile>$(SolutionDir)\build\keys\keypair.snk</AssemblyOriginatorKeyFile> | ||
| <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)\build\keys\keypair.snk</AssemblyOriginatorKeyFile> |
There was a problem hiding this comment.
$(SolutionDir) is only defined inside an IDE, $(MSBuildThisFileDirectory) is defined by msbuild.
Relative path would have worked as well but may look ambiguous.
|
Can you add misc files to the solution as well: |
MaxKsyunz
force-pushed
the
dev-os-2.0-integ-local-abstractions-no-build
branch
from
6663010
to
622321a
Compare
| @@ -12,10 +12,10 @@ EndProject | |||
| Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "scripts", "build\scripts\scripts.fsproj", "{D6997ADC-E933-418E-831C-DE1A78897493}" | |||
| EndProject | |||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tests", "tests", "{6C4A2627-AF22-4388-9DF7-7A9AEACFD635}" | |||
| ProjectSection(SolutionItems) = preProject | |||
There was a problem hiding this comment.
What's the purpose to these whitespace changes in this file?
There was a problem hiding this comment.
These were done by dotnet cli.
It looks like ProjectSection is an element under Project and so needs an indent.
| ProjectSection(SolutionItems) = preProject | ||
| tests\Directory.Build.props = tests\Directory.Build.props | ||
| tests\.runsettings = tests\.runsettings | ||
| EndProjectSection |
There was a problem hiding this comment.
These were done by the dotnet cli.
It looks like ProjectSection is an element under Project and so needs an indent.
| @@ -49,29 +44,3 @@ Supports: | |||
| 2. Released versions | |||
| * `MAJOR.MINOR.PATH` where `MAJOR` is still supported as defined by the EOL policy of OpenSearch. | |||
| * Note if the version exists but is not yet released it will resolve as a build candidate | |||
|
|
|||
There was a problem hiding this comment.
Curious why this is removed from the readme?
There was a problem hiding this comment.
It was asked for in the upstream PR.
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
MaxKsyunz
force-pushed
the
dev-os-2.0-integ-local-abstractions-no-build
branch
from
622321a
to
4488a70
Compare
|
@Yury-Fridlyand, as per your comment, I added |
Yury-Fridlyand
deleted the
dev-os-2.0-integ-local-abstractions-no-build
branch
abstractions\srctoOpenSearch.sln.Signed-off-by: MaxKsyunz maxk@bitquilltech.com