Added new datetime functions and aliases to PPL #281

matthewryanwells · 2023-06-30T20:33:26Z

Description

This PR adds multiple datetime functions and aliases to PPL.

The following aliases are added:

Alias	Original Function
day_of_week	dayofweek
day_of_month	day
hour_of_day	hour
minute_of_hour	minute
second_of_minute	second
day_of_year	dayofyear
month_of_year	month
week_of_year	week

The following functions are added:

minute_of_day
time_format

Issues Resolved

No related issue

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…tests Signed-off-by: Matthew Wells <matthew.wells@improving.com>

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

codecov · 2023-06-30T20:34:38Z

Codecov Report

❗ No coverage uploaded for pull request base (integ-ppl-function-support@1ec696d). Click here to learn what that means.
The diff coverage is n/a.

@@                      Coverage Diff                      @@
##             integ-ppl-function-support     #281   +/-   ##
=============================================================
  Coverage                              ?   97.30%           
  Complexity                            ?     4442           
=============================================================
  Files                                 ?      388           
  Lines                                 ?    11000           
  Branches                              ?      785           
=============================================================
  Hits                                  ?    10704           
  Misses                                ?      289           
  Partials                              ?        7

Flag	Coverage Δ
sql-engine	`97.30% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

docs/user/ppl/functions/datetime.rst

ppl/src/main/antlr/OpenSearchPPLLexer.g4

ppl/src/main/antlr/OpenSearchPPLParser.g4

…ation Signed-off-by: Matthew Wells <matthew.wells@improving.com>

ppl/src/main/antlr/OpenSearchPPLLexer.g4

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

* Added new functions, and alias' to PPL Signed-off-by: Matthew Wells <matthew.wells@improving.com>

) * Added new datetime functions and aliases to PPL (#281) * Added new functions, and alias' to PPL Signed-off-by: Matthew Wells <matthew.wells@improving.com> * removed message about functions not working with dates with 0 month/day as those dates don't exist Signed-off-by: Matthew Wells <matthew.wells@improving.com> * changed documentation to be in alphabetical order Signed-off-by: Matthew Wells <matthew.wells@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com>

* Added new functions, and alias' to PPL Signed-off-by: Matthew Wells <matthew.wells@improving.com>

) * Added new datetime functions and aliases to PPL (#281) * Added new functions, and alias' to PPL Signed-off-by: Matthew Wells <matthew.wells@improving.com> * removed message about functions not working with dates with 0 month/day as those dates don't exist Signed-off-by: Matthew Wells <matthew.wells@improving.com> * changed documentation to be in alphabetical order Signed-off-by: Matthew Wells <matthew.wells@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

) (opensearch-project#1832) * Added new datetime functions and aliases to PPL (#281) * Added new functions, and alias' to PPL Signed-off-by: Matthew Wells <matthew.wells@improving.com> * removed message about functions not working with dates with 0 month/day as those dates don't exist Signed-off-by: Matthew Wells <matthew.wells@improving.com> * changed documentation to be in alphabetical order Signed-off-by: Matthew Wells <matthew.wells@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com> (cherry picked from commit e44d983) Co-authored-by: Matthew Wells <matthew.wells@improving.com>

) * Added new datetime functions and aliases to PPL (#281) * Added new functions, and alias' to PPL Signed-off-by: Matthew Wells <matthew.wells@improving.com> * removed message about functions not working with dates with 0 month/day as those dates don't exist Signed-off-by: Matthew Wells <matthew.wells@improving.com> * changed documentation to be in alphabetical order Signed-off-by: Matthew Wells <matthew.wells@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

) (opensearch-project#1838) * Added new datetime functions and aliases to PPL (#281) * Added new functions, and alias' to PPL Signed-off-by: Matthew Wells <matthew.wells@improving.com> * removed message about functions not working with dates with 0 month/day as those dates don't exist Signed-off-by: Matthew Wells <matthew.wells@improving.com> * changed documentation to be in alphabetical order Signed-off-by: Matthew Wells <matthew.wells@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com> (cherry picked from commit e44d983) Co-authored-by: Matthew Wells <matthew.wells@improving.com>

matthewryanwells added 2 commits June 30, 2023 13:09

Added new functions, and alias' to PPL, including documentation, and …

014f37b

…tests Signed-off-by: Matthew Wells <matthew.wells@improving.com>

fixed incorrect test and updated documentation

88ae668

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

matthewryanwells requested review from MaxKsyunz, Yury-Fridlyand, forestmvey, acarbonetto and GumpacG as code owners June 30, 2023 20:33

matthewryanwells added 3 commits June 30, 2023 13:38

fixed multiple doctest failures

3dd14b3

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

Fixed another doctest failure

50a9b43

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

fixed time_format doctest failure

f267d07

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

Yury-Fridlyand approved these changes Jun 30, 2023

View reviewed changes

Alphabetized parser and lexer, extended dashes under name in document…

7b927df

…ation Signed-off-by: Matthew Wells <matthew.wells@improving.com>

GumpacG approved these changes Jun 30, 2023

View reviewed changes

Yury-Fridlyand approved these changes Jun 30, 2023

View reviewed changes

ppl/src/main/antlr/OpenSearchPPLLexer.g4 Outdated Show resolved Hide resolved

forestmvey approved these changes Jul 4, 2023

View reviewed changes

acarbonetto approved these changes Jul 4, 2023

View reviewed changes

Alphabized lexer

6fa6917

Signed-off-by: Matthew Wells <matthew.wells@improving.com>

matthewryanwells merged commit 2c6c623 into integ-ppl-function-support Jul 4, 2023

matthewryanwells deleted the dev-ppl-function-support branch July 4, 2023 17:47

matthewryanwells added a commit that referenced this pull request Jul 7, 2023

Added new datetime functions and aliases to PPL (#281)

e9a2853

* Added new functions, and alias' to PPL Signed-off-by: Matthew Wells <matthew.wells@improving.com>

matthewryanwells added a commit that referenced this pull request Jul 7, 2023

Added new datetime functions and aliases to PPL (#281)

0c4a0b3

* Added new functions, and alias' to PPL Signed-off-by: Matthew Wells <matthew.wells@improving.com>

matthewryanwells added a commit that referenced this pull request Jul 11, 2023

Added new datetime functions and aliases to PPL (#281)

dbc24f8

* Added new functions, and alias' to PPL Signed-off-by: Matthew Wells <matthew.wells@improving.com>

matthewryanwells added a commit that referenced this pull request Jul 11, 2023

Added new datetime functions and aliases to PPL (#281)

ec261f4

* Added new functions, and alias' to PPL Signed-off-by: Matthew Wells <matthew.wells@improving.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added new datetime functions and aliases to PPL #281

Added new datetime functions and aliases to PPL #281

matthewryanwells commented Jun 30, 2023

codecov bot commented Jun 30, 2023 •

edited

Loading

Added new datetime functions and aliases to PPL #281

Added new datetime functions and aliases to PPL #281

Conversation

matthewryanwells commented Jun 30, 2023

Description

Issues Resolved

Check List

codecov bot commented Jun 30, 2023 • edited Loading

Codecov Report

codecov bot commented Jun 30, 2023 •

edited

Loading