Add support for date_nanos and tests.
#337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
requested review from
MaxKsyunz,
forestmvey,
acarbonetto and
GumpacG
as code owners
MitchellGale
approved these changes
Aug 11, 2023
Codecov Report
@@ Coverage Diff @@
## integ-add-date-nanos-2.x #337 +/- ##
===========================================================
Coverage 97.51% 97.51%
Complexity 4656 4656
===========================================================
Files 408 408
Lines 11930 11931 +1
Branches 829 829
===========================================================
+ Hits 11634 11635 +1
Misses 289 289
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
GumpacG
reviewed
Aug 11, 2023
integ-test/src/test/resources/indexDefinitions/datatypes_index_mapping.json
Outdated
Show resolved
Hide resolved
GumpacG
approved these changes
Aug 14, 2023
matthewryanwells
approved these changes
Aug 14, 2023
acarbonetto
reviewed
Aug 14, 2023
|
@Yury-Fridlyand we should add tests to parallel the expected features of date_nanos.
|
acarbonetto
reviewed
Aug 14, 2023
| + " FROM %s", TEST_INDEX_DATE_FORMATS); | ||
| JSONObject result = executeQuery(query); | ||
| verifySchema(result, | ||
| schema("hour_minute_second_OR_t_time", null, "time")); |
There was a problem hiding this comment.
can you change this to hour_minute_second_millis instead? The point of using the date_nano type is to include fractions of a second.
There was a problem hiding this comment.
I use t_time here, it includes up to 9 digits of fsp.
There was a problem hiding this comment.
but the verifyDataRows doesn't include any units of precision? Maybe include data that has fractions of a second?
Yury-Fridlyand
force-pushed
the
integ-add-date-nanos-2.x
branch
from
b480916
to
5381a6f
Compare
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
force-pushed
the
dev-add-date-nanos-2.x
branch
from
7a04f82
to
25a2007
Compare
Added tests and rebased on upstream/main. |
GumpacG
approved these changes
Aug 16, 2023
acarbonetto
approved these changes
Aug 16, 2023
Yury-Fridlyand
merged commit 8ef676b
into
integ-add-date-nanos-2.x
19 of 20 checks passed
6 tasks
MitchellGale
pushed a commit
that referenced
this pull request
Aug 21, 2023
* Add support for `date_nanos` and tests. (#337) * Add support for `date_nanos` and tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add more IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix in IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR feedback. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Spotless Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
added a commit
that referenced
this pull request
Aug 22, 2023
* Add support for `date_nanos` and tests. (#337) * Add support for `date_nanos` and tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add more IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Typo fix in IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR feedback. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Spotless Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 752da21) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
normanj-bitquill
pushed a commit
that referenced
this pull request
Oct 25, 2024
…) (opensearch-project#2020) * Add support for `date_nanos` and tests. (#337) * Add support for `date_nanos` and tests. * Add more IT. --------- * Typo fix in IT. * Address PR feedback. * Spotless --------- (cherry picked from commit 752da21) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restore support for
date_nanostype. Initially was added in opensearch-project#360 and removed in opensearch-project#1314 by mistake.Issues Resolved
opensearch-project#1954
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.