Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Company Name as of AOS-231 #9

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Update Company Name as of AOS-231 #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql-jdbc/src/TableauConnector/opensearch_sql_jdbc/manifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<connector-plugin class='opensearch_jdbc' superclass='jdbc' plugin-version='1.1.0.0' name='OpenSearch' version='18.1' min-version-tableau='2021.1'>
<vendor-information>
<company name="OpenSearch for ES"/>
<company name="OpenSearch Project"/>
<support-link url="https://github.com/opensearch-project/sql"/>
</vendor-information>
<connection-customization class="opensearch_jdbc" enabled="true" version="10.0">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Line 9 for "Vendor"?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"OpenSearch JDBC doesn't make sense to me as the Vendor. What do other connectors do?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only dremio example: https://github.com/dremio-hub/tableau-connector/blob/master/manifest.xml

Expand Down