Add command LSET #312
Merged
Add command LSET #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java/client/src/main/java/glide/api/commands/ListBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/ListBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/ListBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/integTest/src/test/java/glide/TransactionTestUtilities.java
Outdated
Show resolved
Hide resolved
acarbonetto
reviewed
May 27, 2024
java/client/src/main/java/glide/api/commands/ListBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/ListBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/ListBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
| String response = client.lset(key, index, element).get(); | ||
| assertEquals(OK, response); | ||
| String[] updatedList = client.lrange(key, 0, -1).get(); | ||
| assertArrayEquals(updatedList, expectedList); |
There was a problem hiding this comment.
I think the expected list at this point should be:
String[] expectedList = {"zero", "three", "two", "one"};
since you're only modifying the value at index 0
There was a problem hiding this comment.
Lpush pushes each element in the input array to the front of the list, so the list starts as {"one", "two", "three", "four"}
| @@ -298,6 +302,9 @@ private static Object[] listCommands(BaseTransaction<?> transaction) { | |||
| 4L, // linsert(listKey3, AFTER, value2, value2) | |||
| new String[] {listKey3, value3}, // blpop(new String[] { listKey3 }, 0.01) | |||
| new String[] {listKey3, value1}, // brpop(new String[] { listKey3 }, 0.01) | |||
| 2L, // lpush(listKey5, new String[] {value2, value3}) | |||
| OK, // lset(listKey5, 0, value1) | |||
| new String[] {value1, value2} // lrange(listKey5, 0, -1) | |||
There was a problem hiding this comment.
Suggested change
| new String[] {value1, value2} // lrange(listKey5, 0, -1) | |
| new String[] {value1, value3} // lrange(listKey5, 0, -1) |
aren't we changing the value at index 0 only?
There was a problem hiding this comment.
since lpush pushes to the front, the list looks like {value3, value2} after first being pushed to, and after setting index 0 it becomes {value1, value2}
added 2 commits
May 27, 2024 17:09
Yury-Fridlyand
approved these changes
May 28, 2024
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
Yury-Fridlyand
approved these changes
May 28, 2024
tjzhang-BQ
added a commit
that referenced
this pull request
May 28, 2024
* Add command LSET --------- Co-authored-by: TJ Zhang <tj.zhang@improving.com>
acarbonetto
pushed a commit
that referenced
this pull request
May 28, 2024
Add command LSET (#312) * Add command LSET --------- Co-authored-by: TJ Zhang <tj.zhang@improving.com>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
Add command LSET (#312) * Add command LSET --------- Co-authored-by: TJ Zhang <tj.zhang@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding command LSet