Python: add OBJECT IDLETIME command #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yury-Fridlyand
approved these changes
May 28, 2024
| @@ -3545,7 +3545,7 @@ async def object_encoding(self, key: str) -> Optional[str]: | |||
| await self._execute_command(RequestType.ObjectEncoding, [key]), | |||
| ) | |||
|
|
|||
| async def object_freq(self, key: str) -> int: | |||
| async def object_freq(self, key: str) -> Optional[int]: | |||
There was a problem hiding this comment.
Do you need to update changelog for that?
There was a problem hiding this comment.
I think because the original implementation and this change will be under the same version (0.4.0) its probably fine? Idk, what do you think?
aaron-congo
merged commit a6b1aa4
into
python/integ_acongo_object_idletime
6 checks passed
aaron-congo
added a commit
that referenced
this pull request
May 28, 2024
tjzhang-BQ
pushed a commit
that referenced
this pull request
May 28, 2024
Python: add OBJECT IDLETIME command (#313)
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
Python: add OBJECT IDLETIME command (#313)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redis.io/docs/latest/commands/object-idletime/