Adding command LMove
#319
Merged
Adding command LMove
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzhang-BQ
force-pushed
the
java/dev_tjz_lmove
branch
from
0d9ebf6
to
d7069a1
Compare
added 2 commits
May 28, 2024 17:46
| * @param destination The key to the destination list. | ||
| * @param wherefrom The direction the element should be removed from. | ||
| * @param whereto The direction the element should be added to. | ||
| * @return The popped element or null. |
There was a problem hiding this comment.
Suggested change
| * @return The popped element or null. | |
| * @return The popped element or <code>null</code>. |
There was a problem hiding this comment.
when source doesnt exist it returns null, should that be included in the javadoc?
If source does not exist, the value nil is returned and no operation is performed.
https://redis.io/docs/latest/commands/lmove/
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/ListDirection.java
Outdated
Show resolved
Hide resolved
java/integTest/src/test/java/glide/TransactionTestUtilities.java
Outdated
Show resolved
Hide resolved
Yury-Fridlyand
approved these changes
May 29, 2024
tjzhang-BQ
added a commit
that referenced
this pull request
May 29, 2024
tjzhang-BQ
added a commit
that referenced
this pull request
May 29, 2024
* Adding command `LMove` (#319) * Adding command LMove --------- Co-authored-by: TJ Zhang <tj.zhang@improving.com> * addressing review comments * undo renaming of the lmpop arguments * spotless --------- Co-authored-by: TJ Zhang <tj.zhang@improving.com>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Adding command `LMove` (#319) * Adding command LMove --------- Co-authored-by: TJ Zhang <tj.zhang@improving.com> * addressing review comments * undo renaming of the lmpop arguments * spotless --------- Co-authored-by: TJ Zhang <tj.zhang@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add command LMove