Adding command BLMove #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarbonetto
approved these changes
May 30, 2024
java/client/src/main/java/glide/api/commands/ListBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/ListBaseCommands.java
Outdated
Show resolved
Hide resolved
| @@ -3832,6 +3833,44 @@ public T lmove( | |||
| return getThis(); | |||
| } | |||
|
|
|||
| /** | |||
| * Blocks the connection until it pops Atomically pops and removes the left/right-most element to | |||
There was a problem hiding this comment.
Suggested change
| * Blocks the connection until it pops Atomically pops and removes the left/right-most element to | |
| * Blocks the connection until it atomically pops and removes the left/right-most element to |
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
|
note: BLMOVE is already considered for timeout |
so if we encounter a command that is blocking and not yet included in |
|
All existing at the moment commands with timout added to |
Yury-Fridlyand
approved these changes
May 30, 2024
java/client/src/main/java/glide/api/commands/ListBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/ListBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/integTest/src/test/java/glide/TransactionTestUtilities.java
Outdated
Show resolved
Hide resolved
aaron-congo
pushed a commit
that referenced
this pull request
May 31, 2024
* Adding command BLMove (#324) Co-authored-by: TJ Zhang <tj.zhang@improving.com>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Adding command BLMove (#324) Co-authored-by: TJ Zhang <tj.zhang@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.