Add FUNCTION STATS command.
#333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
aaron-congo
reviewed
Jun 6, 2024
| ExpectedReturnType::FunctionStatsReturnType => match value { | ||
| // TODO reuse https://github.com/Bit-Quill/glide-for-redis/pull/331 and https://github.com/aws/glide-for-redis/pull/1489 | ||
| Value::Map(map) => { | ||
| if map[0].0 == Value::BulkString(b"running_script".into()) { |
There was a problem hiding this comment.
Do we need to check that the map isn't empty before indexing into it?
There was a problem hiding this comment.
This line checks that first key in the map is "running_script". The value for that key could be empty, but I don't touch it there.
FUNCTION STATS should never return empty reponse/array/map.
java/client/src/main/java/glide/api/commands/ScriptingAndFunctionsClusterCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/ScriptingAndFunctionsClusterCommands.java
Outdated
Show resolved
Hide resolved
aaron-congo
approved these changes
Jun 6, 2024
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
merged commit 783942b
into
java/integ_yuryf_fstats
38 of 44 checks passed
Yury-Fridlyand
added a commit
that referenced
this pull request
Jun 13, 2024
* Add `FUNCTION STATS` command. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Complete `FUNCTION STATS` implementation. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Minor rust code grooming. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
added a commit
that referenced
this pull request
Jun 14, 2024
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
added a commit
that referenced
this pull request
Jun 14, 2024
Add `FUNCTION STATS` command. (#333) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
Add `FUNCTION STATS` command. (#333) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends and based on #333 on #328
Note: IT is incomplete, because
FUNCTION KILLtests don't work