-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FUNCTION STATS
command.
#333
Add FUNCTION STATS
command.
#333
Conversation
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
ExpectedReturnType::FunctionStatsReturnType => match value { | ||
// TODO reuse https://github.com/Bit-Quill/glide-for-redis/pull/331 and https://github.com/aws/glide-for-redis/pull/1489 | ||
Value::Map(map) => { | ||
if map[0].0 == Value::BulkString(b"running_script".into()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to check that the map isn't empty before indexing into it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line checks that first key in the map is "running_script". The value for that key could be empty, but I don't touch it there.
FUNCTION STATS
should never return empty reponse/array/map.
java/client/src/main/java/glide/api/commands/ScriptingAndFunctionsClusterCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/ScriptingAndFunctionsClusterCommands.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
783942b
into
java/integ_yuryf_fstats
* Add `FUNCTION STATS` command. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Complete `FUNCTION STATS` implementation. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Minor rust code grooming. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Add `FUNCTION STATS` command. (#333) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Add `FUNCTION STATS` command. (#333) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Depends and based on #333 on #328
Note: IT is incomplete, because
FUNCTION KILL
tests don't work