Added Async Babushka Client and support for Cluster Mode. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified benchmarking so it can handle multiple clients running.
Updated lib.rs with types for SuccessCallback and FailureCallback to automate binding creation. Reformatted project structure for babushkaclient and also the benchmarkApp. Cleaned up babushkaclient -Got rid of Callback indexes -Fixed naming conventions
SanHalacogluImproving
force-pushed
the
go-babushka-async-client-raw-ffi
branch
from
ebde38f
to
0286e1e
Compare
SanHalacogluImproving
requested review from
jonathanl-bq,
Yury-Fridlyand and
acarbonetto
acarbonetto
reviewed
Nov 11, 2023
go/README.md
Outdated
| # Summary - Go Wrapper | ||
|
|
||
| This module contains a POC Go-client wrapper that connects to the `Babushka`-rust-client. The rust client connects to | ||
| redis, while this wrapper provides Go-language binding. The objective of this wrapper is to provide a thin-wrapper |
There was a problem hiding this comment.
Suggested change
| redis, while this wrapper provides Go-language binding. The objective of this wrapper is to provide a thin-wrapper | |
| Redis, while this wrapper provides Go-language binding. The objective of this wrapper is to provide a thin-wrapper |
go/README.md
Outdated
| @@ -0,0 +1,55 @@ | |||
| # Summary - Go Wrapper | |||
|
|
|||
| This module contains a POC Go-client wrapper that connects to the `Babushka`-rust-client. The rust client connects to | |||
There was a problem hiding this comment.
Suggested change
| This module contains a POC Go-client wrapper that connects to the `Babushka`-rust-client. The rust client connects to | |
| This module contains a POC Go-client wrapper that connects to the `Babushka`-Rust-client. The Rust client connects to |
go/README.md
Outdated
|
|
||
| 1. A Go client: wrapper to rust-client. | ||
| 2. An examples script: to sanity test go-babushka and similar go-clients against a redis host. | ||
| 3. A benchmark app: to performance benchmark test go-babushka and similar go-clients against a redis host. |
There was a problem hiding this comment.
Suggested change
| 3. A benchmark app: to performance benchmark test go-babushka and similar go-clients against a redis host. | |
| 3. A benchmark app: to performance benchmark go-babushka and standard Go clients against a Redis host. |
go/README.md
Outdated
| 1) Build the Babushka-Core: | ||
| Navigate to `babushka/babushka-core`. | ||
| Run the command: `cargo build --release`. | ||
| 2) Build the go-babushka within the Go Benchmarks: |
There was a problem hiding this comment.
Suggested change
| 2) Build the go-babushka within the Go Benchmarks: | |
| 2) Build go-babushka within the Go Benchmarks: |
go/README.md
Outdated
| Navigate to `babushka/babushka-core`. | ||
| Run the command: `cargo build --release`. | ||
| 2) Build the go-babushka within the Go Benchmarks: | ||
| Change your current directory to the babushkaclient in `babushka/go/benchmarks/babushkaclient`. |
There was a problem hiding this comment.
Suggested change
| Change your current directory to the babushkaclient in `babushka/go/benchmarks/babushkaclient`. | |
| Change your current directory to: `babushka/go/benchmarks/babushkaclient`. |
go/README.md
Outdated
| * `concurrentTasks`: Number of concurrent tasks | ||
| * `clients`: one of: all|jedis|lettuce|babushka | ||
| * `clientCount`: Client count | ||
| * `host`: redis server host url |
There was a problem hiding this comment.
Suggested change
| * `host`: redis server host url | |
| * `host`: Redis server host url |
go/README.md
Outdated
| * `clients`: one of: all|jedis|lettuce|babushka | ||
| * `clientCount`: Client count | ||
| * `host`: redis server host url | ||
| * `port`: redis server port number |
There was a problem hiding this comment.
Suggested change
| * `port`: redis server port number | |
| * `port`: Redis server port number |
go/README.md
Outdated
| * `host`: redis server host url | ||
| * `port`: redis server port number | ||
| * `tls`: redis TLS configured | ||
| * `clusterModeEnabled`: redis cluster mode enabled |
There was a problem hiding this comment.
Suggested change
| * `clusterModeEnabled`: redis cluster mode enabled | |
| * `clusterModeEnabled`: Redis cluster mode enabled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.