Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let 'bitbag_cms_render_block' also accept template variable #148

Closed
stefandoorn opened this issue Jun 15, 2018 · 1 comment · Fixed by #155
Closed

Let 'bitbag_cms_render_block' also accept template variable #148

stefandoorn opened this issue Jun 15, 2018 · 1 comment · Fixed by #155
Labels
Easy Pick

Comments

@stefandoorn
Copy link
Contributor

No description provided.

@bitbager
Copy link
Member

It would just require adding the nullable $template parameter here - https://github.com/BitBagCommerce/SyliusCmsPlugin/blob/master/src/Twig/Extension/RenderBlockExtension.php and fix the Spec. Marking it as easy pick.

stefandoorn added a commit to stefandoorn/SyliusCmsPlugin that referenced this issue Jun 19, 2018
@stefandoorn
Add template argument to bitbag_cms_render_block twig function (closes …
ecd076e 
…BitBagCommerce#148)
@stefandoorn stefandoorn mentioned this issue Jun 19, 2018
Merged
patrick477 added a commit that referenced this issue Jun 20, 2018
@patrick477
Merge pull request #155 from stefandoorn/render-template
3407816 
Add template argument to bitbag_cms_render_block twig function (closes #148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Pick
Projects
None yet
Milestone
No milestone
2 participants
@stefandoorn @bitbager