Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix correct signature of implode #389

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Conversation

Jibbarth
Copy link
Contributor

@Jibbarth Jibbarth commented Aug 11, 2021

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets N/A
License MIT

Hello,

The FormHerrorsFlashHelper use implode function with a deprecated signature, and this is not more available in PHP8.

image

This PR fix the signature use 🙂

@KrisFlorq KrisFlorq merged commit 50681a4 into BitBagCommerce:master Aug 12, 2021
@Jibbarth Jibbarth deleted the patch-1 branch August 12, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants