Feature/video media read #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Harvel218
commented
Dec 21, 2021
Harvel218
commented
| Q | A |
|---|---|
| Bug fix? | no/yes |
| New feature? | no/yes |
| BC breaks? | no/yes |
| Deprecations? | no/yes |
| Related tickets | fixes #X, partially #Y, mentioned in #Z |
| License | MIT |
|
Configure your Git not to submit |
ghost
reviewed
Dec 21, 2021
| } | ||
|
|
||
| function htmlToString(item) { | ||
| return String(item).replace(/&/g, '&').replace(/</g, '<').replace(/>/g, '>').replace(/"/g, '"'); |
There was a problem hiding this comment.
its not longer than 120 chars - formatter isnt considering it to format (and i cant just maunaly do this because i have format on save :( )
Can it be ommited?
There was a problem hiding this comment.
can be omitted, however imho it adds readability to code
|
|
||
| function checkName(item) { | ||
| if (item) return item; | ||
| else return 'Empty name'; |
There was a problem hiding this comment.
add newline between 23 and 24, else is not needed
| `<div class="media-list__item"> | ||
| <label for="${media.code}" class="media-list__item__label"><strong>${trimValue( | ||
| htmlToString(checkName(media.name)) | ||
| )}</strong></strong> (${trimValue(media.code)})</label> |
| </div>` | ||
| ) | ||
| .join(''); | ||
| return output; |
|
|
||
| function insertImageHtml(data) { | ||
| const output = data | ||
| .map( |
| } | ||
| }, | ||
| error(jqXHR, textStatus, errorThrown) { | ||
| console.log(`ajax error ${textStatus} ${errorThrown}`); |
| page: pageNumber, | ||
| limit: limit, | ||
| }; | ||
| const shallowEncoded = $.param(myObject); |
|
|
||
| $.ajax({ | ||
| type: 'GET', | ||
| url: route + '?' + shallowDecoded, |
| totalPages = numPages(data.total); | ||
| changePage(currentPage, 'video-btn-next', 'video-btn-prev', 'video-page-number'); | ||
| const element = CKEDITOR.document.getById('media-video-list'); | ||
| if (element) { |
| controlStyle: 'width: 100%', | ||
| onKeyUp: function () { | ||
| phrase = this.getValue(); | ||
| if (oldValue === phrase) { |
ghost
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.