Provide better extensibility by using the NewsletterSubscriptionInterface properly #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjanfrans
force-pushed
the
use-interface
branch
from
9c7c668
to
80f47fb
Compare
leszczuu
approved these changes
Aug 5, 2021
arjanfrans
changed the title
|
Hello can You please fix build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment it is impossible to extend this library without overriding all the services.
In this PR I use the NewsletterSubscriptionInterface everywhere, instead of directly injecting the NewsletterSubscriptionHandler implementation.
This opens up the ability to extend the plugin by adding your own implemention of the interface.