Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sylius 1.13 support and wishlist code update #212

Merged
merged 35 commits into from
May 13, 2024
Merged

Sylius 1.13 support and wishlist code update #212

merged 35 commits into from
May 13, 2024

Conversation

arek31
Copy link
Member

@arek31 arek31 commented Jul 4, 2023 •
edited by marekrzytki
Loading

This PR includes:

  • support for Sylius 1.13
  • drop support for Sylius 1.11
  • bump PHP version to 8.1
  • cover more logic with php spec tests
  • code quality (use interfaces instead of classes, constructor property promotion)
  • php unit integration and functional test cases

arek31 and others added 30 commits July 4, 2023 16:58
@arek31
OP-169: Adjust code for PHP8.1 style
545b9b4
@arek31
OP-169: Add first batch of PHPSpec tests
9b5b0e6
@arek31
OP-169: Adjust PHP version in composer.json to 8.1
d2cb898
@arek31
OP-169: Misc source code improvements
c931b7b
@arek31
OP-169: Add additional command handler specs
f66016d
@arek31
OP-169: Finish adding command handler specs, adjust code style of exi…
dd7c4e8 
…sting specs
@marekrzytki
Merge remote-tracking branch 'origin/master' into OP-169-wishlist-cod…
3b03bf6 
…e-update

# Conflicts:
#	composer.json
#	src/Command/Wishlist/AddProductToSelectedWishlist.php
#	src/CommandHandler/Wishlist/CreateNewWishlistHandler.php
#	src/CommandHandler/Wishlist/CreateWishlistHandler.php
#	src/Context/WishlistContext.php
#	src/EventSubscriber/CreateNewWishlistSubscriber.php
#	src/Resolver/WishlistsResolver.php
@marekrzytki
Resolve conflicts
24eb2c0
@marekrzytki
Fix php spec tests
b56ff7d
@marekrzytki
Remove php 8.0 from build
1488d11
@marekrzytki
Remove doubled service import
7afc297
@marekrzytki
Fix incorrect message bus declaration
2371ef2
@marekrzytki
Add package json file for Sylius 1.13
17243d6
@marekrzytki
Fix interface
f6cbb01
@marekrzytki
Fix package json name for Sylius 1.13
cfb4787
@marekrzytki
Try to fix tests for Sylius 1.13
581fd42
@marekrzytki
Fix bundles file for Sylius 1.13, add wait after ajax call in behat
dab6d96
@marekrzytki
Fix semantic versioning in build for Sylius 1.13
6d859ee
@marekrzytki
Add lchrusciel api test case package
770bb4a
@marekrzytki
Add wishlist repository test
12ec451
@marekrzytki
Fix indent and add php unit tests for CI
d729666
@marekrzytki
Add functional wishlist api tests
283efed
@marekrzytki
Downgrade nelmio/alice package for symfony 5.4 support
6065307
@marekrzytki
Add phpunit bridge package
d5d0ccc
@marekrzytki
Drop support for Sylius 1.11, add support for Sylius 1.13
8982c3d
@marekrzytki
Add php unit configuration file to git
f76111f
@marekrzytki
Remove configuration for Sylius 1.11
07fa90c
@marekrzytki
Revert php unit bridge package
e295552
@marekrzytki
Add prefer source for sylius package
862e17d
@marekrzytki
Split API responses between Sylius version
4a65164
@marekrzytki marekrzytki changed the title OP-169: Wishlist code update Sylius 1.13 support and wishlist code update May 8, 2024
@marekrzytki marekrzytki marked this pull request as ready for review May 8, 2024 09:26
senghe
senghe requested changes May 11, 2024
View reviewed changes
spec/CommandHandler/Wishlist/AddProductToWishlistHandlerSpec.php Outdated Show resolved Hide resolved
spec/CommandHandler/Wishlist/ExportWishlistToCsvHandlerSpec.php Outdated Show resolved Hide resolved
spec/CommandHandler/Wishlist/RemoveSelectedProductsFromWishlistHandlerSpec.php Show resolved Hide resolved
spec/Factory/CsvSerializerFactorySpec.php Outdated Show resolved Hide resolved
spec/Factory/CsvSerializerFactorySpec.php Outdated Show resolved Hide resolved
src/Resolver/TokenUserResolver.php Outdated Show resolved Hide resolved
tests/Functional/Api/WishlistTest.php Show resolved Hide resolved
tests/Functional/FunctionalTestCase.php Show resolved Hide resolved
...nctional/Responses/Expected/Api/WishlistTest/1.12/test_user_can_add_product_to_wishlist.json Show resolved Hide resolved
tests/Integration/Repository/WishlistRepositoryTest.php Show resolved Hide resolved
@marekrzytki marekrzytki merged commit f02f2c1 into master May 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marekrzytki marekrzytki marekrzytki left review comments

@senghe senghe senghe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arek31 @senghe @marekrzytki