blank url is handled correctly now + prepared 1.0.1a release

BitBotFactory · Jun 5, 2017 · baf0e89 · baf0e89
1 parent fc86132
commit baf0e89
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -9,8 +9,8 @@ android {
         applicationId "de.artem.lendingwidget"
         minSdkVersion 16
         targetSdkVersion 25
-        versionCode 2
-        versionName "1.0.1"
+        versionCode 3
+        versionName "1.0.1a"
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
     }
     buildTypes {

diff --git a/app/src/main/java/com/artem/lendingwidget/LendingWidgetConfigureActivity.kt b/app/src/main/java/com/artem/lendingwidget/LendingWidgetConfigureActivity.kt
@@ -111,13 +111,15 @@ class LendingWidgetConfigureActivity : AppCompatActivity() {
     }
 
     internal fun tryConnection() {
-        toggleViews(false)
 
         // TODO handle https
         var url = mUrlEditText.text.toString()
         if (url.isBlank()) {
+            Toast.makeText(this, getString(R.string.error_blank_url, mUrlEditText.text), Toast.LENGTH_LONG).show()
             return
         }
+
+        toggleViews(false)
         if (url.toLowerCase().startsWith("http://")) {
             url = url.substring(7)
         }

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -7,4 +7,5 @@
     <string name="error_connection">An error occured while trying to connect to %1$s</string>
     <string name="error_log">Error log</string>
     <string name="target_spinner_title">Conversion currency</string>
+    <string name="error_blank_url">Please enter a URL</string>
 </resources>