frontend: label change #2788

NicolaLS · 2024-07-01T15:21:22Z

Label utxos that are to change addresses from our account (subaccounts
respectively) as change to give the user more information about the utxo
when selecting it in coin control.

frontends/web/src/locales/en/app.json

Beerosagos

LGTM! Only one doubt about the first commit comment:

Possible false negative in case the user used another wallet and derived some change address behind the current change gap limit.

I think that in case the user received on a change address uncovered by our gap limit he will miss the whole utxo, not only the change badge. wdyt?

benma · 2024-07-03T10:18:18Z

backend/coins/btc/account.go

@@ -873,12 +874,19 @@ func (account *Account) SpendableOutputs() []*SpendableOutput {
 		panic(err)
 	}
 	for outPoint, txOut := range utxos {
+		isChange := false
+		for _, subacc := range account.subaccounts {


this is the same code as

bitbox-wallet-app/backend/coins/btc/account.go

Lines 722 to 726 in 81b3b25

for _, subacc := range account.subaccounts {

if subacc.changeAddresses.LookupByScriptHashHex(scriptHashHex) != nil {

return true

}

}

would be nice to move that to a method on Account, with a unit test, so it can be reused

Maybe it would be better to make the AccountAddress change aware and then use getAddress instead of IsChange, here is how it could look like:
3b7fa12

I think it makes sense for AccounAdress to know whether it is change or not. Often times we'll want to get some address anyways, and even if we really only care for the IsChange value the overhead (looking at the receiveAdresses) does not matter at all since a hash map is used for the lookup (O(1)) I think this would make the code easier to understand.

Please lmk what you think @benma

(added three commits after the initial backend commit, can squash them in case we want to do it like this)

please squash

NicolaLS · 2024-07-04T19:00:06Z

LGTM! Only one doubt about the first commit comment:

Possible false negative in case the user used another wallet and derived some change address behind the current change gap limit.

I think that in case the user received on a change address uncovered by our gap limit he will miss the whole utxo, not only the change badge. wdyt?

Right, I don't know why I thought he would see the utxo. I'll amend the commit message, thanks.

thisconnect

frontend LGTM

frontends/web/src/components/badge/badge.module.css

frontends/web/src/routes/account/send/utxos.tsx

thisconnect

frontend LGTM

thisconnect · 2024-07-17T07:10:41Z

backend/coins/btc/account.go

@@ -873,12 +874,19 @@ func (account *Account) SpendableOutputs() []*SpendableOutput {
 		panic(err)
 	}
 	for outPoint, txOut := range utxos {
+		isChange := false
+		for _, subacc := range account.subaccounts {


please squash

Beerosagos · 2024-08-01T09:26:51Z

@NicolaLS is this ready for BE review or does it need other changes?

NicolaLS · 2024-08-01T12:21:17Z

@NicolaLS is this ready for BE review or does it need other changes?

@Beerosagos It's ready, I added the IsChange method to the account and added a test (also fixed test package name). I still think something like this would be better rather than adding a method to account, but this could be a future PR/refactor too.

Beerosagos · 2024-08-06T09:35:36Z

backend/coins/btc/account_test.go

@@ -13,7 +13,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.

-package btc_test


@benma I guess there was a reason why this package was named btc_test, but I'm not sure which was it. Is it ok to move inside btc package?

@benma could you take a look at this ? I can't imagine any reason why tests that test code from a certain package should be outside of that package (unit tests). but if there is/was a reason I can just undo the change in this PR.

I already addressed the other change requests from @Beerosagos

Beerosagos · 2024-08-06T09:48:58Z

backend/coins/btc/account.go

@@ -907,6 +902,17 @@ func (account *Account) VerifyExtendedPublicKey(signingConfigIndex int) (bool, e
 	return false, nil
 }

+// IsChange returns true if there is an address corresponding to the provided scriptHashHex in our
+// accounts change address chain. It returns false if no addresss can be found.


typo: addresss

Beerosagos · 2024-08-06T09:55:19Z

backend/coins/btc/account_test.go

 	require.NoError(t, err)
 	require.NotEmpty(t, address)
 	require.Equal(t, base64.StdEncoding.EncodeToString([]byte("signature")), signature)

 }
+
+func TestIsChange(t *testing.T) {


Would be nice also to test for false positives: non-change addresses should not be mistakenly identified as change

Add a boolean field to the response of the utxos enpoint (the getUTXOS handler) that tells us whether the utxo is to a change address of our wallet or not. Also: - Add IsChange method on btc.Account that returns a boolean. True if the provided scriptHashHex is in our change address chain and false if not. - Add a unit test for the IsChange method. - Fix btc account and coin unit test package names.

Label utxos that are to change addresses from our account (subaccounts respectively) as change to give the user more information about the utxo when selecting it in coin control.

NicolaLS force-pushed the label-change branch from 1d2e188 to 0e9a2af Compare July 1, 2024 15:34

thisconnect requested a review from Beerosagos July 2, 2024 20:07

thisconnect reviewed Jul 2, 2024

View reviewed changes

frontends/web/src/locales/en/app.json Show resolved Hide resolved

Beerosagos reviewed Jul 3, 2024

View reviewed changes

benma reviewed Jul 3, 2024

View reviewed changes

NicolaLS force-pushed the label-change branch 7 times, most recently from 23bf35a to 8da7d2c Compare July 8, 2024 14:49

thisconnect approved these changes Jul 9, 2024

View reviewed changes

thisconnect requested changes Jul 10, 2024

View reviewed changes

frontends/web/src/components/badge/badge.module.css Outdated Show resolved Hide resolved

frontends/web/src/routes/account/send/utxos.tsx Show resolved Hide resolved

NicolaLS requested a review from benma July 15, 2024 14:25

NicolaLS force-pushed the label-change branch from 8da7d2c to 5be871d Compare July 15, 2024 14:25

thisconnect approved these changes Jul 17, 2024

View reviewed changes

NicolaLS force-pushed the label-change branch 2 times, most recently from 9d97273 to 49b49c7 Compare July 17, 2024 16:45

NicolaLS force-pushed the label-change branch from 49b49c7 to c39d35c Compare July 30, 2024 13:22

NicolaLS force-pushed the label-change branch from c39d35c to 109e632 Compare August 1, 2024 12:24

Beerosagos requested changes Aug 6, 2024

View reviewed changes

NicolaLS force-pushed the label-change branch 4 times, most recently from 40ad717 to bca4b7c Compare August 6, 2024 12:55

NicolaLS force-pushed the label-change branch from bca4b7c to 2132b6a Compare August 20, 2024 16:22

NicolaLS added 2 commits September 2, 2024 09:23

frontend: label change in coin control

bfa4c9a

Label utxos that are to change addresses from our account (subaccounts respectively) as change to give the user more information about the utxo when selecting it in coin control.

NicolaLS force-pushed the label-change branch from 2132b6a to bfa4c9a Compare September 2, 2024 15:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

frontend: label change #2788

frontend: label change #2788

NicolaLS commented Jul 1, 2024

Beerosagos left a comment

benma Jul 3, 2024

NicolaLS Jul 5, 2024

NicolaLS Jul 5, 2024

thisconnect Jul 17, 2024

NicolaLS commented Jul 4, 2024

thisconnect left a comment

thisconnect left a comment

thisconnect Jul 17, 2024

Beerosagos commented Aug 1, 2024

NicolaLS commented Aug 1, 2024 •

edited

Loading

Beerosagos Aug 6, 2024

NicolaLS Sep 2, 2024

Beerosagos Aug 6, 2024

Beerosagos Aug 6, 2024

	for _, subacc := range account.subaccounts {
	if subacc.changeAddresses.LookupByScriptHashHex(scriptHashHex) != nil {
	return true
	}
	}

frontend: label change #2788

Are you sure you want to change the base?

frontend: label change #2788

Conversation

NicolaLS commented Jul 1, 2024

Beerosagos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NicolaLS commented Jul 4, 2024

thisconnect left a comment

Choose a reason for hiding this comment

thisconnect left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Beerosagos commented Aug 1, 2024

NicolaLS commented Aug 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NicolaLS commented Aug 1, 2024 •

edited

Loading