Frontend let account render in offline #2847
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to improve consistency & aesthetics, we'd like to use our revamped Message component for our Status component. Please note that our Banner component uses Status. Therefore, with this change, Banner will also use Message component.
Using our new ContentWrapper in order for components that are using Status and were outside of the content view, to look like they are in the view. It's done to improve aesthetics. Also, they will be scrolling with the content instead of "sticking on top" like it used to be.
created the new component `GlobalBanners`, extracting it out from `app.tsx`. We use this component in `account.tsx`, `accountsummary.tsx`, and all of the settings pages. The reason for this is because we'd like to move them out of `app.tsx` so they're in the document flow of the page instead of living separately in `app.tsx` (visually placed above the page view).
This would fix the flickering when changing accounts and could allow the user to get a receive address in offline mode. Unfortunatelly there are multiple issues with this: - offline error only showing once - receive probably does not know which address range to use and could lead to unwanted address-reuse - backend seems to not play along well in offline mode but somewhat works If we go this way we could add various skeletons to the account view so that it is clear which elements are still loading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.