Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend/backend: pass final tx. note to sendtx and remove propose-tx-note handler #2861

Merged
merged 1 commit into from
Aug 31, 2024

Commits on Aug 26, 2024

  1. frontend/backend: pass tx. note to sendtx

    Pass the final transaction note to the sendtx handler on submit (send)
    instead of remembering a proposed transaction note which is set
    separately using the propose-tx-note handler.
    
    Currently there is no benefit of having a separate handler for the
    transaction note for the active proposal. It was separated in this
    commit because typing in the note field would cause the other fields to
    be validated/calculated: 4eb692c
    
    However since the backend does not perform any calculations or
    validation on this handler, the final note can be submitted when
    clicking send (calling the sendtx handler).
    NicolaLS committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    bde57c4 View commit details
    Browse the repository at this point in the history