frontend: don't convert to fiat twice in send #2868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fiat amount does not have to be calculated when receiving the response from submitting the tx. proposal because the `result.amount` is exactly the same as the `amount` in the components state. When this state is set we already convert to fiat.
NicolaLS
force-pushed
the
remove-update-fiat-argument
branch
from
fb01480
to
18c71b7
Compare
|
Unfortunately it is currently needed with this change it introduces a bug: when the user clicks "Send all" / "Send selected coin" the fiat field isn't updated. |
@thisconnect oh right...mb should have noticed this. Looks like there is no way around it actually because we would not want to calculate the "all" amount in the frontend, we just propse with "sendall: true" and then use the returned amount. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fiat amount does not have to be calculated when receiving the response from submitting the tx. proposal because the
result.amountis exactly the same as theamountin the components state. When this state is set we already convert to fiat.