Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: add confirmation checkbox for "show mnemonic" dialog #2869

Merged

Conversation

shonsirsha
Copy link
Collaborator

Preview:
ZA
ZZ

@@ -146,9 +146,10 @@
"understand": "I understand that an incorrect recovery password will create a different wallet"
},
"showMnemonic": {
"description": "You will be presented with your recovery words on your BitBox02, which form a backup of your wallet. Write them down on paper.\n\n<strong>Do not store them digitally or take pictures of it.</strong>\n\n<strong>Do not say the words out loud.</strong>\n\n<strong>This backup is not password-protected.</strong>\n\nAfterwards, you will be asked to confirm each word.",
"description": "The device will display the recovery words, which form a backup of your wallet. Write them down on paper.\n\n<strong>Do not store them digitally or take pictures of it.</strong>\n\n<strong>Do not say the words out loud.</strong>\n\n<strong>This backup is not password-protected.</strong>\n\nAfterwards, you will be asked to confirm each word.",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only for review/dev purposes. We need to change this on locize.

Copy link
Collaborator

@thisconnect thisconnect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested LGTM

please update locize once this is merged to master.

also check lint, probably you'll need to do npx locize-cli format frontends/web/src/locales --format json

@shonsirsha shonsirsha force-pushed the frontend-showmnemonic-checkbox branch from 18415b4 to a76b799 Compare August 27, 2024 08:01
@shonsirsha shonsirsha merged commit be29710 into BitBoxSwiss:master Aug 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants