staging-pocketsell -> master #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mock API calls: 1. getExchangeSellSupported 2. getSellExchangeSupportedAccounts
`firmwareUpdateDialogOpen`. It's done to make the dialog controllable from other pages such as the new sell page.
Conflicts: frontends/web/src/components/sidebar/sidebar.tsx frontends/web/src/routes/account/info/buyReceiveCTA.tsx frontends/web/src/routes/exchange/exchange.tsx frontends/web/src/routes/exchange/info.tsx frontends/web/src/routes/exchange/utils.ts frontends/web/src/routes/settings/components/device-settings/firmware-setting.tsx Also modified imports in: - frontends/web/src/routes/exchange/components/exchangeselectionradio.tsx - frontends/web/src/routes/exchange/components/infocontent.tsx
Payment requests have been supported by bitbox02 firmware since v9.19.0. This integrates the feature in the app, mocking a testnet payment request in the Pocket widget section. Once the Pocket sell widget integration is completed the mock function will be removed. Note: to test this it is necessary to flash a dev device with a FW having the test merchant enabled.
Exchange logic was largely implemented in the frontend. With this, all the logic is moved to the backend, and the whole code is simplified. Main changes: - getExchangeDeals now has three params: coin, region and action (buy/sell) and returns already filtered exchange deals, with best deal flag already set - mv sell.tsx buysell.tsx: this component now has an action param, that allows to display different deals on the base of the enabled buy/sell tab. - all the /buy/ path has been moved to /exchange/ - a lot of frontend logic (e.g. to find the best deal) is not necessary anymore and has been removed. - pocket sell mockup button removed, as it is not necessary anymore Still todo: we should check if the bb02 firmware supports silent payments and can sell through Pocket using a backend endpoint instead of just checking the version in the frontend. This will be done in a future commit.
and update pocket exchange page title.
This inserts a new `SupportsPaymentRequests` method in the device interface and creates a new related endpoint to check if the connected device supports sell action in the exchange section.
There was a bug in the payment request implementation that didn't correctly support mempool.space fees and resulted in a fee error during the tx proposal on production environment. This commit moves the fee target selection for payment requests in the BE and fixes the bug. It also fixes a bug in the tx proposal error handling.
Also removed the old (thus unused) pocket T&C translation keys.
shonsirsha
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
This file (and its css) are unused. Feel free to delete them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.