Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethereum: remove Goerli testnet #2978

Merged
merged 1 commit into from
Oct 18, 2024
Merged

ethereum: remove Goerli testnet #2978

merged 1 commit into from
Oct 18, 2024

Conversation

benma
Copy link
Contributor

@benma benma commented Oct 11, 2024

Goerli testnet shut down April 2020.

See also: BitBoxSwiss/bitbox02-firmware#1317

@benma benma requested a review from Beerosagos October 11, 2024 07:40
Copy link
Collaborator

@Beerosagos Beerosagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK with a small nit :)

@@ -117,8 +117,6 @@ func sortAccounts(accounts []accounts.Interface) {
switch ethCoin.ChainID() {
case params.MainnetChainConfig.ChainID.Uint64():
return 4, true
case params.GoerliChainConfig.ChainID.Uint64():
return 5, true
case params.SepoliaChainConfig.ChainID.Uint64():
return 6, true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return 6, true
return 5, true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed!

Goerli testnet shut down April 2020.
@benma benma merged commit fa8b3c4 into BitBoxSwiss:master Oct 18, 2024
7 checks passed
@benma benma deleted the rm-goerli branch October 18, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants