Skip to content
This repository has been archived by the owner on Oct 8, 2024. It is now read-only.

Commit

Permalink
loki: its now possible to use bucketnames
Browse files Browse the repository at this point in the history
grafana/loki#3069 is partially addressed;
however an empty S3 url is still required to avoid loki reaching out to sts.dummy.amazonaws.com
  • Loading branch information
james-callahan committed Jun 23, 2021
1 parent 5f66fdb commit 0bfdb4f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
5 changes: 0 additions & 5 deletions loki/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,3 @@ This setup uses the new boltdb-shipper shipped with Loki 2.0.0.
- ruler: alerting [info](https://grafana.com/docs/loki/latest/rules/)
This application includes a sidecar that picks up rules from kubernetes `ConfigMap` with the label `loki_rule` set.
- table-manager: (not used)


## Config

For AWS IAM roles for service accounts (IRSA) to work, it's important that the `.WithCredentials` method is never called https://github.com/grafana/loki/blob/8c1fe88409fe832b45da1f8f3cdd8116d81f4048/vendor/github.com/cortexproject/cortex/pkg/chunk/aws/s3_storage_client.go#L133. This means you need to pass an s3 url.
3 changes: 2 additions & 1 deletion loki/files/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ server:
http_server_write_timeout: 1m
storage_config:
aws:
s3: s3:///${LOKI_STORAGE_CONFIG_AWS_BUCKETNAMES}
s3: s3:///
bucketnames: ${LOKI_STORAGE_CONFIG_AWS_BUCKETNAMES}
sse_encryption: true
boltdb_shipper:
shared_store: aws
Expand Down

0 comments on commit 0bfdb4f

Please sign in to comment.