Multi input mint #94
Open
Multi input mint #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 19, 2020 08:20
Updating to match slp-sdk
Prettier format for master branch of slp-sdk
Prettier formatting on Address.ts
SLPInterfaces linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for
fundingAddressandfundingWifas arrays inTokenType1.sendDue to different linting systems, the easiest way to review this PR is to check changes to
TokenType1.tsandSLPInterfaces.tsat this PR: https://github.com/josephroyking/slp-sdk/pull/3/filesThis highlights the only material code changes (in this PR, the numerous formatting deltas make things confusing).
Summary of changes
IMintConfiginSLPInterfaces.tsso thatfundingAddressandfundingWifacceptstring | string[](previouslystring)mintfunction inTokenType1.tsto handle array inputs forfundingAddressandfundingWifby following similar logic to thesendfunction. I.e., if the function receives astringforfundingAddressandfundingWif, it executes as normal before this change. If the function receivesarraysforfundingAddressandfundingWif, it executes the code reviewable here:https://github.com/josephroyking/slp-sdk/blob/multi-input-mint/src/TokenType1.ts#L133
See lines 133 to 196. The code changes are parsing changes to process output of different format from
bitboxNetwork.getAllSlpBalancesAndUtxos(mintConfig.fundingAddress);--- which itself already accepts array inputs.