-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[notes] Add support for multiple authors #50
Conversation
6255573
to
2bcb95a
Compare
@sduenas please review when you have time. |
@vchrombie I have this error when running your patch
This is the input that I use:
|
Hi @sduenas
This is the same error when you try to generate notes (with
I used the same and it worked fine for me
@jjmerchante, could you also help to test the patch just to have another view? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch looks good to me but we need to improve the tests.
My fault, I was using an older version and not the one from your branch. |
dcd9fd8
to
9340173
Compare
Hi @sduenas, please have a look at this PR when you have free time. |
This commit adds code to support export of multiple authors from the changelog entry. You can add more than one author to the changelog entry by defining them as ``` author: - John Smith <jsmith@example.com> - John Doe <jdoe@example.com> ``` Signed-off-by: Venu Vardhan Reddy Tekula <venuvardhanreddytekula8@gmail.com>
9340173
to
5decf0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for merging this @sduenas. |
This PR adds code to support export of multiple authors from the changelog entry.
Resolves #49