Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick workaround for BLOB as TEXT problem (#2247) #2248

Open
wants to merge 3 commits into
base: v0.6
Choose a base branch
from

Conversation

kashikoibumi
Copy link

Quick workaround for BLOB as TEXT problem (#2247).

This patch fixes each SQL query to be both workable with BLOB-keys and TEXT-keys.
In each query, it tries first BLOB-key by using sqlite3.Binary() function.
When it failed, then it tries next TEXT-key by using CAST(? AS TEXT) syntax.

The modifications are all around the code base where SQL queries exist, but the logic is simple.

@kashikoibumi
Copy link
Author

I have added a script to revert the BLOB-keys into TEXT-keys.

  • revert_blob_to_text.sh

By applying this script, old version of PyBitmessage before this patch can be run again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant