Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserOperation Request Router #57

Merged
merged 3 commits into from
Sep 19, 2024
Merged

UserOperation Request Router #57

merged 3 commits into from
Sep 19, 2024

Conversation

bh2smith
Copy link
Collaborator

@bh2smith bh2smith commented Sep 19, 2024

User description

Recent version of near-ca added a better EIP712TypedData type for our request router.

We update the encodeSignRequest to call into a custom built request router that should support several important Safe signature requests.


PR Type

dependencies, enhancement


Description

  • Updated the near-ca dependency version from ^0.5.2 to ^0.5.6 in package.json.
  • The new version of near-ca includes a better EIP712TypedData type for the request router.

Changes walkthrough 📝

Relevant files
Dependencies
package.json
Update `near-ca` dependency version                                           

package.json

  • Updated near-ca dependency version from ^0.5.2 to ^0.5.6
+1/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

@mintbase-codium-pr-agent
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

@mintbase-codium-pr-agent
Copy link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Best practice
Pin the dependency version to avoid potential breaking changes from automatic updates

Pin the version of near-ca to a specific version instead of using the caret (^)
version range. This can help ensure that the exact version tested with your
application is used, preventing automatic updates that could introduce breaking
changes without your knowledge.

package.json [47]

-"near-ca": "^0.5.6",
+"near-ca": "0.5.6",
 
Suggestion importance[1-10]: 9

Why: Pinning the version of near-ca ensures that the exact version tested with the application is used, which can prevent unexpected issues from automatic updates. This is a best practice for maintaining stability in dependencies.

9

@bh2smith bh2smith changed the title Pin Version Update on near-ca UserOperation Request Router Sep 19, 2024
Copy link
Collaborator Author

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks pretty good here, but there are a few important todos remaining. We also don't know yet if all these encodings are indeed correct.

Furthermore, our broadcast EVM method will need to handle other SignRequestMethods. This is something we can't do until we implement wallet connect.

@bh2smith bh2smith merged commit 32800b9 into main Sep 19, 2024
1 check passed
@bh2smith bh2smith deleted the upgrade branch September 19, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant