Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/theme json sass #17

Merged
merged 10 commits into from
Jan 27, 2022
Merged

Fix/theme json sass #17

merged 10 commits into from
Jan 27, 2022

Conversation

cr0ybot
Copy link
Member

@cr0ybot cr0ybot commented Jan 27, 2022

  • Remove string juggling from theme.json -> sass values, import values directly.
  • Include theme.json in the list of files watched for the styles task.
  • Run gulp directly from npm scripts since we're using a gulpfile.

@cr0ybot cr0ybot requested a review from philhoyt January 27, 2022 05:47
@cr0ybot cr0ybot merged commit 17daea1 into main Jan 27, 2022
@cr0ybot cr0ybot deleted the fix/theme-json-sass branch January 27, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philhoyt philhoyt Awaiting requested review from philhoyt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cr0ybot