73 #87

l3r8yJ · 2023-09-09T20:21:07Z

closes #73

PR-Codex overview

This PR focuses on making several changes to the codebase. The notable changes include:

Deleting the Registry.java and RegistryTest.java files
Modifying the answers.properties file to update the token and registry properties
Adding dependencies for cactoos and easy-random-core in the pom.xml file
Modifying the Start.java file to use Mono from Reactor
Adding a license header to the package-info.java file
Modifying the Conversation.java interface to use Mono from Reactor
Adding the Unsubscribe.java file to handle the /chatid command
Adding a license header to the TokenOf.java file
Adding a test case for the TokenOf class

The following files were skipped due to too many changes: src/test/java/io/blamer/bot/text/TokenOfTest.java, src/main/java/io/blamer/bot/agents/tg/TgBot.java, src/test/java/extension/UpdateWithTokenExtension.java, src/main/java/io/blamer/bot/conversation/routes/Token.java, src/test/java/io/blamer/bot/conversation/routes/TokenTest.java, src/test/java/io/blamer/bot/agents/tg/TgBotTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

zoeself · 2023-09-09T20:21:09Z

@l3r8yJ thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

codecov · 2023-09-09T20:22:05Z

Codecov Report

Patch coverage: 46.15% and project coverage change: -23.25% ⚠️

Comparison is base (b626110) 80.89% compared to head (bc915d5) 57.65%.
Report is 2 commits behind head on master.

❗ Current head bc915d5 differs from pull request most recent head 6f1a3c0. Consider uploading reports for the commit 6f1a3c0 to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##             master      #87       +/-   ##
=============================================
- Coverage     80.89%   57.65%   -23.25%     
  Complexity       32       32               
=============================================
  Files            10       12        +2     
  Lines            89      111       +22     
  Branches          2        1        -1     
=============================================
- Hits             72       64        -8     
- Misses           17       47       +30

Files Changed	Coverage Δ
...va/io/blamer/bot/conversation/routes/Registry.java	`20.00% <0.00%> (-74.45%)`	⬇️
...io/blamer/bot/conversation/routes/Unsubscribe.java	`20.00% <20.00%> (ø)`
src/main/java/io/blamer/bot/agents/tg/TgBot.java	`66.66% <35.71%> (-28.34%)`	⬇️
.../java/io/blamer/bot/conversation/routes/Start.java	`100.00% <100.00%> (ø)`
.../java/io/blamer/bot/conversation/routes/Token.java	`100.00% <100.00%> (ø)`
src/main/java/io/blamer/bot/text/TokenOf.java	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zoeself · 2023-09-09T20:31:10Z

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-09-12T20:18:59.270984.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

h1alexbel

@l3r8yJ take a look at my comments, please

src/main/java/io/blamer/bot/conversation/Conversation.java

h1alexbel · 2023-09-10T07:41:13Z

src/main/java/io/blamer/bot/conversation/routes/ChatId.java

+ * Chat id command.
+ */
+@Component("/chatid")
+public class ChatId implements Conversation {


@l3r8yJ maybe a better name for this class will be RegisterChat?

@h1alexbel Honestly, I'd rather make this command like /unsubscribe because we already have /register

@l3r8yJ we don't have register chat id command.
We have registry, but it's a different flow

@h1alexbel I think you can get by with a registry, storing the chat id + token at the same time

@l3r8yJ you can, but still now we have a separate flow for it, simply because register chat is like user registration in blamer, while register token is actually different flow

What do you think?

@h1alexbel honestly, I don't see any cases where a user would want to save a chat without receiving notifications

what's the motivation behind it?

@l3r8yJ actually yes, agree.
So we will reduce amount of commands simply to: /unsub and /token. On token we will validate if the chat already exists in db

@l3r8yJ can you apply these changes to diagrams in order to sync up?

@h1alexbel i'll create a puzzle

src/main/java/io/blamer/bot/conversation/routes/ChatId.java

src/main/java/io/blamer/bot/text/TokenOf.java

src/main/resources/answers.properties

src/test/java/extension/UpdateWithTokenExtension.java

src/test/java/io/blamer/bot/text/TokenOfTest.java

l3r8yJ · 2023-09-10T16:57:47Z

@h1alexbel take a look, please

src/main/java/io/blamer/bot/conversation/routes/Registry.java

zoeself · 2023-09-11T00:41:05Z

@h1alexbel Don't forget to close this ticket before the deadline (2023-09-12T20:18:59). You are past the first half of the allowed period.

l3r8yJ · 2023-09-11T08:00:25Z

@h1alexbel take a look, please

h1alexbel · 2023-09-11T08:34:43Z

@l3r8yJ commented on mixing flows

h1alexbel · 2023-09-12T07:47:23Z

@l3r8yJ here is new version #88

zoeself · 2023-09-12T08:11:14Z

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Иван Иванчук added 9 commits September 9, 2023 23:18

cactoos & easy random

5ee8763

props

be8ed05

chat-id

f242d4f

to mono

9990e71

to mono

c3b69da

token as class

9e41d2a

ext

4bab2a6

puzzles

96d63ee

to mono

53c3259

zoeself assigned h1alexbel Sep 9, 2023

zoeself added the @h1alexbel label Sep 9, 2023

h1alexbel requested changes Sep 10, 2023

View reviewed changes

Иван Иванчук added 3 commits September 10, 2023 19:41

javadoc

1b9ba43

review fixes

4c0c1c7

typo

9fb115f

l3r8yJ requested a review from h1alexbel September 10, 2023 16:57

h1alexbel reviewed Sep 10, 2023

View reviewed changes

src/main/java/io/blamer/bot/conversation/routes/Registry.java Outdated Show resolved Hide resolved

Иван Иванчук added 2 commits September 11, 2023 10:49

puzzle

e183cef

puzzle

bc915d5

l3r8yJ requested a review from h1alexbel September 11, 2023 08:00

remove registry

6f1a3c0

h1alexbel closed this Sep 12, 2023

zoeself unassigned h1alexbel Sep 12, 2023

zoeself removed the @h1alexbel label Sep 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

73 #87

73 #87

l3r8yJ commented Sep 9, 2023 •

edited by pr-codex bot

Loading

zoeself commented Sep 9, 2023

codecov bot commented Sep 9, 2023 •

edited

Loading

zoeself commented Sep 9, 2023

h1alexbel left a comment

h1alexbel Sep 10, 2023

l3r8yJ Sep 10, 2023

h1alexbel Sep 10, 2023

l3r8yJ Sep 10, 2023

h1alexbel Sep 10, 2023

l3r8yJ Sep 11, 2023 •

edited

Loading

h1alexbel Sep 11, 2023

h1alexbel Sep 11, 2023 •

edited

Loading

l3r8yJ Sep 11, 2023

h1alexbel Sep 11, 2023

l3r8yJ commented Sep 10, 2023

zoeself commented Sep 11, 2023

l3r8yJ commented Sep 11, 2023

h1alexbel commented Sep 11, 2023

h1alexbel commented Sep 12, 2023

zoeself commented Sep 12, 2023

73 #87

73 #87

Conversation

l3r8yJ commented Sep 9, 2023 • edited by pr-codex bot Loading

PR-Codex overview

zoeself commented Sep 9, 2023

codecov bot commented Sep 9, 2023 • edited Loading

Codecov Report

zoeself commented Sep 9, 2023

h1alexbel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

l3r8yJ Sep 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

h1alexbel Sep 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

l3r8yJ commented Sep 10, 2023

zoeself commented Sep 11, 2023

l3r8yJ commented Sep 11, 2023

h1alexbel commented Sep 11, 2023

h1alexbel commented Sep 12, 2023

zoeself commented Sep 12, 2023

l3r8yJ commented Sep 9, 2023 •

edited by pr-codex bot

Loading

codecov bot commented Sep 9, 2023 •

edited

Loading

l3r8yJ Sep 11, 2023 •

edited

Loading

h1alexbel Sep 11, 2023 •

edited

Loading