chore: remove unused getWebPreferences method (electron#30160)

Blaquez-home · Jul 19, 2021 · 612361c · 612361c
1 parent a329842
commit 612361c
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 20 deletions.
diff --git a/shell/browser/api/electron_api_web_contents.cc b/shell/browser/api/electron_api_web_contents.cc
@@ -3052,14 +3052,6 @@ std::vector<base::FilePath> WebContents::GetPreloadPaths() const {
   return result;
 }
 
-v8::Local<v8::Value> WebContents::GetWebPreferences(
-    v8::Isolate* isolate) const {
-  auto* web_preferences = WebContentsPreferences::From(web_contents());
-  if (!web_preferences)
-    return v8::Null(isolate);
-  return gin::ConvertToV8(isolate, *web_preferences->preference());
-}
-
 v8::Local<v8::Value> WebContents::GetLastWebPreferences(
     v8::Isolate* isolate) const {
   auto* web_preferences = WebContentsPreferences::From(web_contents());
@@ -3719,7 +3711,6 @@ v8::Local<v8::ObjectTemplate> WebContents::FillObjectTemplate(
       .SetMethod("getZoomFactor", &WebContents::GetZoomFactor)
       .SetMethod("getType", &WebContents::GetType)
       .SetMethod("_getPreloadPaths", &WebContents::GetPreloadPaths)
-      .SetMethod("getWebPreferences", &WebContents::GetWebPreferences)
       .SetMethod("getLastWebPreferences", &WebContents::GetLastWebPreferences)
       .SetMethod("getOwnerBrowserWindow", &WebContents::GetOwnerBrowserWindow)
       .SetMethod("inspectServiceWorker", &WebContents::InspectServiceWorker)

diff --git a/spec-main/api-web-contents-spec.ts b/spec-main/api-web-contents-spec.ts
@@ -503,16 +503,6 @@ describe('webContents module', () => {
     });
   });
 
-  describe('getWebPreferences() API', () => {
-    afterEach(closeAllWindows);
-    it('should not crash when called for devTools webContents', async () => {
-      const w = new BrowserWindow({ show: false });
-      w.webContents.openDevTools();
-      await emittedOnce(w.webContents, 'devtools-opened');
-      expect(w.webContents.devToolsWebContents!.getWebPreferences()).to.be.null();
-    });
-  });
-
   describe('openDevTools() API', () => {
     afterEach(closeAllWindows);
     it('can show window with activation', async () => {

diff --git a/typings/internal-electron.d.ts b/typings/internal-electron.d.ts
@@ -57,7 +57,6 @@ declare namespace Electron {
   interface WebContents {
     _loadURL(url: string, options: ElectronInternal.LoadURLOptions): void;
     getOwnerBrowserWindow(): Electron.BrowserWindow;
-    getWebPreferences(): Electron.WebPreferences;
     getLastWebPreferences(): Electron.WebPreferences;
     _getPreloadPaths(): string[];
     equal(other: WebContents): boolean;