Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .net 6 #359

Merged
merged 5 commits into from
Mar 6, 2022
Merged

Update to .net 6 #359

merged 5 commits into from
Mar 6, 2022

Conversation

larsk2009
Copy link
Collaborator

@larsk2009 larsk2009 commented Nov 11, 2021

Seems to me this is the only thing necessary for using .NET 6? Otherwise this is atleast a starting point. Resolves #358.

It builds on my machine so the error is mostlikely only because the SDK used on the agent is still using .NET 5.x

@chrissainty
Copy link
Member

I'm thinking that now might be the time to move to collocated JS files and JS modules. That way, developers will no longer need to reference the JS file in the host page. We could also think about scoped CSS as well. This could really simplify the installation process.

What do you think, @larsk2009?

@larsk2009
Copy link
Collaborator Author

Yes for sure! I can have look when I have time.

Copy link

@alensweepr alensweepr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@MrGeneric
Copy link

Hey, just curious if there is a release planned with this .net 6 update anytime soon? Thanks for the hard work!

@larsk2009
Copy link
Collaborator Author

Well the .net6 part is not so difficult, but I tried to move to collocated JS files/modules and had some issues there, but I don't remember anymore what exactly.

@chrissainty chrissainty marked this pull request as draft March 5, 2022 11:49
@chrissainty chrissainty marked this pull request as ready for review March 6, 2022 14:28
@chrissainty
Copy link
Member

chrissainty commented Mar 6, 2022

@larsk2009 Thanks for your initial work on this PR. I've adding in nullable reference types and implicit usings, as per the standard in .NET 6 projects. I've also removed all of the JavaScript as I have a plan to replace the focus trap with a Blazor native version. Something I'll do in another PR to try and keep some tidiness.

The next version of the modal will be a breaking change and as it's been a year or so since the last release I'm tempted to go hard on fixing some stuff which is a bit crappy and make v7 a big step forward.

@chrissainty chrissainty merged commit 97f2b35 into main Mar 6, 2022
@chrissainty chrissainty deleted the feature/dotnet-6 branch March 6, 2022 14:33
@larsk2009
Copy link
Collaborator Author

@chrissainty sounds like a great idea! I've not really been using Blazor in general much anymore lately, so didn't have much time to work on this anymore. Really appreciate you picking up this .net6 stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] .NET6
4 participants