-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to .net 6 #359
Update to .net 6 #359
Conversation
I'm thinking that now might be the time to move to collocated JS files and JS modules. That way, developers will no longer need to reference the JS file in the host page. We could also think about scoped CSS as well. This could really simplify the installation process. What do you think, @larsk2009? |
Yes for sure! I can have look when I have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice
Hey, just curious if there is a release planned with this .net 6 update anytime soon? Thanks for the hard work! |
Well the .net6 part is not so difficult, but I tried to move to collocated JS files/modules and had some issues there, but I don't remember anymore what exactly. |
@larsk2009 Thanks for your initial work on this PR. I've adding in nullable reference types and implicit usings, as per the standard in .NET 6 projects. I've also removed all of the JavaScript as I have a plan to replace the focus trap with a Blazor native version. Something I'll do in another PR to try and keep some tidiness. The next version of the modal will be a breaking change and as it's been a year or so since the last release I'm tempted to go hard on fixing some stuff which is a bit crappy and make v7 a big step forward. |
@chrissainty sounds like a great idea! I've not really been using Blazor in general much anymore lately, so didn't have much time to work on this anymore. Really appreciate you picking up this .net6 stuff! |
Seems to me this is the only thing necessary for using .NET 6? Otherwise this is atleast a starting point. Resolves #358.
It builds on my machine so the error is mostlikely only because the SDK used on the agent is still using .NET 5.x