Improve Windows Build #272
Conversation
Force the windows build process to execute a nuget restore against the librdkafka solution, so that the required zlib dependencies are built before the librdkafka project requires them.
gyp was corrupting the output files when it tried to link them so an empty array will have to suffice.
|
Hi I already posted this as an issue, but nuget does not seem to run the restore during npm install, is there a way to explicitly run it? I've already set up VS to automatically check and download missing packages. Thanks |
|
This merge added that functionality, when did you test this? And did you make sure |
|
Definitely have nuget in my path. I'm pulling it from the public npm, appears to be installing 2.1.1. Not sure if it's related, but I have VS 2013 Express installed (doesn't appear you can download older versions without an MSDN license). |
|
Don't think NPM reflects the bleeding-edge updates here. Try installing from the repo. |
|
Fixes the Nuget issue, but still doesn't build Build FAILED. "C:\dev\poc\proj\projcoreservices\proj-r\node_modules\node-rdkafka\deps\librdkafka\win32\librdkafka.sln" (librdkafkacpp target) (1) -> "C:\dev\poc\proj\projcoreservices\proj-r\node_modules\node-rdkafka\deps\librdkafka\win32\librdkafka.sln" (librdkafkacpp target) (1) -> Time Elapsed 00:00:26.58 |
Execute
nuget restorebefore we build thelibrdkafkaproject, so that windows users will have the requirednugetdependencies for the build. Improves #248 and should hopefully be enough to close #45