-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest miniscript #160
Latest miniscript #160
Conversation
b1eb7bf
to
010c058
Compare
Rebased on master. Fuzzing is still broken because we need a patched version of bitcoin-hashes. There is also a weird bug for 1.48.0. |
As suggested on IRC please try rust-bitcoin/rust-bitcoin commit c1c76756a65d1eb046ac934425603c83dbcd0d94 for bitcoin_hashes in fuzz/Cargo.toml. |
Heads up, |
7a1b268
to
59fcc1b
Compare
For future reference: on IRC we noticed that this commit actually doesn't work, because it includes changes to the |
a8dd18c
to
d63c980
Compare
bitcoin-hashes no longer provides ToHex and elements is an optional dependency, so I copied hex.rs from elements, which was itself copied from the previous version of bitcoin-hashes. Once bitcoin-hashes is fixed we can easily switch over to that. Fuzzing is updated. We have multiple versions of bitcoin_hashes. slip21 requires bitcoin_hashes < 0.12.0, which resolves to 0.11. We have to be careful to overwrite 0.12.0 but not 0.11. The jet benches are updated. FFI is updated.
d63c980
to
91ecf06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 91ecf06
Updates simplicity to the latest bitcoin(-hashes), elements and elements-miniscript.
I had to copy hex.rs because bitcoin-hashes dropped support. We might want to use a stable workaround instead once it exists.
There are also problems in the fuzz and bench crate that need to be resolved.