-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: bulletproofs: use one large ecmult_multi instead of two smaller ones #216
Draft
jonasnick
wants to merge
35
commits into
BlockstreamResearch:master
Choose a base branch
from
jonasnick:bpp_ecmult_multi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngeproof module You can verify this commit with `git diff --color-moved=zebra`
This reverts commit 5437e7b.
Silence a compiler warning about an unitialized use of a scalar in case the user tries to provide a 0-length list of commitments. Also ensures that commitments have normalized field elements when they are loaded into ges.
Add a transcript module for doing a generic Fiat Shamir
norm arg: add verify test vector with vector size > 1
This makes it easy to use Fiat Shamir in when invoking child protocols.
This commit also updates norm argument to use asset_gen instead of G for storing the inner product
For compatibility with exisiting Pedersen commitments data structures, it is necessary to have commitments be of the G_a*v + G*gamma where G_a is asset gen and gamma is blinding factors. However, in BP++ design, the blinding values are along H_vec. In order make these compatible with BP++, we make h0 = G
Commit to digits and multiplicities
Commit to reciprocals of digits as 1/(e + d_i)
Commit to S. Compute l's adaptive to create a zero polynomial
Run the run norm proof argument on the computed C
jonasnick
force-pushed
the
bpp_ecmult_multi
branch
from
February 10, 2023 18:12
3e0b0cf
to
ea5adac
Compare
jonasnick
force-pushed
the
bpp_ecmult_multi
branch
from
February 11, 2023 17:06
ea5adac
to
6afecdd
Compare
jonasnick
force-pushed
the
bpp_ecmult_multi
branch
from
February 11, 2023 17:23
6afecdd
to
f109aa0
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #207.
without this PR
with this PR:
TODO: