Norm arg: allow X and R to be point at infinity #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
jonasnick
force-pushed
the
norm-arg-tests
branch
from
320c890
to
c66aa43
Compare
Add test vector
R is point at infinity but sign is != 0
One function tests prover edge cases, the other tests verifier edge cases.
jonasnick
force-pushed
the
norm-arg-tests
branch
from
c66aa43
to
bf7bf8a
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows X and R to be the point at infinity in norm argument proving and verification. With that change, the verification algorithm should be equivalent to the rust-bulletproofs-pp implementation.
This PR also adds other static test vectors for verify edge cases (corresponding to rust-bulletproofs-pp master)
ge_serialize_extandge_parse_extthat are introduced in open PR Update musig module to BIP MuSig2 v1.0.0-rc.3 #211