Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of "ct: Use volatile "trick" in all fe/scalar cmov implementations" #224

Merged

Commits on Apr 11, 2023

  1. ct: Use volatile "trick" in all fe/scalar cmov implementations

    Apparently clang 15 is able to compile our cmov code into a branch,
    at least for fe_cmov and fe_storage_cmov. This commit makes the
    condition volatile in all cmov implementations (except ge but that
    one only calls into the fe impls).
    
    This is just a quick fix. We should still look into other methods,
    e.g., asm and #457. We should also consider not caring about
    constant-time in scalar_low_impl.h
    
    We should also consider testing on very new compilers in nightly CI,
    see bitcoin-core/secp256k1#864 (comment)
    real-or-random committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    96f4853 View commit details
    Browse the repository at this point in the history