Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSE2/AVX2 build issue #352

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Fix SSE2/AVX2 build issue #352

merged 1 commit into from
Jan 11, 2023

Conversation

t20100
Copy link
Contributor

@t20100 t20100 commented Jan 10, 2023

This PR fixes a regression introduced in PR #347:

shuffle.c uses __SSE2__ and __AVX2__ to set SHUFFLE_USE_SSE2 and SHUFFLE_USE_AVX2 but those macros where never defined since shuffle.c was not built with those flags.

It is similar to Blosc/c-blosc2#436

@FrancescAlted FrancescAlted merged commit c9ddc13 into Blosc:main Jan 11, 2023
@FrancescAlted
Copy link
Member

Thanks @t20100 !

@t20100 t20100 deleted the fix-build branch January 11, 2023 08:30
@t20100 t20100 mentioned this pull request Jun 29, 2023
Closed
@t20100 t20100 mentioned this pull request Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t20100 @FrancescAlted