Fix: CMake Config Version w/o Suffix #548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing to CMake, we cannot append the suffix string in the version file, i.e., have to omit `.dev`. The reason for that is that `VERSION_GREATER_EQUAL` is not that flexible: https://cmake.org/cmake/help/latest/variable/CMAKE_VERSION.html and downstream users comparing against the version will get a `FALSE` result comparing things like ```cmake if (Blosc2_VERSION VERSION_GREATER_EQUAL 2.10.1) ``` if `Blosc2_VERSION` is set to `2.10.2.dev`.
|
No, that's wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing to CMake, we cannot append the suffix string in the version file, i.e., have to omit
.dev.The reason for that is that
VERSION_GREATER_EQUALis not that flexible: https://cmake.org/cmake/help/latest/variable/CMAKE_VERSION.html and downstream users comparing against the version will get aFALSEresult comparing things likeif (Blosc2_VERSION VERSION_GREATER_EQUAL 2.10.1)if
Blosc2_VERSIONis set to2.10.2.dev.Follow-up to #537