Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add None return for peak_times in calculate_feature() of extraFELFeature class #472

Merged
merged 5 commits into from
Sep 29, 2023

Conversation

darshanmandge
Copy link
Contributor

To return None when the peak_times is None in calculate_feature function of extraFELFeature.

@AurelienJaquier AurelienJaquier self-requested a review September 28, 2023 12:51
@AurelienJaquier
Copy link
Collaborator

@alejoe91 I'm pinging you to let you know we are making this change related to LFPy efeature

@alejoe91
Copy link
Contributor

Thanks! Sounds fair :)

@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6aa8937) 87.41% compared to head (12a4df9) 86.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   87.41%   86.13%   -1.28%     
==========================================
  Files          50       50              
  Lines        4330     4336       +6     
==========================================
- Hits         3785     3735      -50     
- Misses        545      601      +56     
Files Coverage Δ
bluepyopt/ephys/efeatures.py 83.98% <14.28%> (-1.47%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AurelienJaquier AurelienJaquier merged commit f7fd66d into BlueBrain:master Sep 29, 2023
5 checks passed
@darshanmandge darshanmandge deleted the extra_efeat_none branch September 29, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants