New scaler: NrnSegmentSomaDistanceStepScaler #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 26, 2024 09:23
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #484 +/- ##
==========================================
+ Coverage 87.31% 87.37% +0.05%
==========================================
Files 50 50
Lines 4329 4347 +18
==========================================
+ Hits 3780 3798 +18
Misses 549 549 ☔ View full report in Codecov by Sentry. |
ilkilic
reviewed
Jan 26, 2024
| distribution (str): distribution of parameter dependent on distance | ||
| from soma. string can contain `distance` and/or `value` as | ||
| placeholders for the distance to the soma and parameter value | ||
| respectivily. It can also contain step_begin and step_end. |
There was a problem hiding this comment.
thanks, fixed in latest commit
There was a problem hiding this comment.
thanks! looks good to merge
ilkilic
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new scaler that can handle step functions. Useful to do a calcium hotspot.
Can also be hoc exportable with this kind of distribution:
{"fun": "{value} * (0.1 + 0.9 * int(({distance} > {step_begin}) & ({distance} < {step_end})))"}