Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytest setup() deprecation in tests #492

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Conversation

wvangeit
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 81.05263% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 87.36%. Comparing base (6679d3c) to head (3c34c85).

Files Patch % Lines
bluepyopt/ephys/create_acc.py 79.16% 15 Missing ⚠️
bluepyopt/ephys/simulators.py 86.95% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
- Coverage   87.37%   87.36%   -0.01%     
==========================================
  Files          50       50              
  Lines        4347     4346       -1     
==========================================
- Hits         3798     3797       -1     
  Misses        549      549              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wvangeit
Copy link
Contributor Author

@AurelienJaquier @anilbey @ilkilic
I fixed the tests that were failing lately, due to changes in pytests. Also made things compatible with python 3.12.

Sorry, for the bid messy PR, but I formatted it with ruff/black too.

Once accepted, can you add python 3.12 as required test in the settings of the repo. Thx.

Copy link
Contributor

@anilbey anilbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks @wvangeit

@anilbey anilbey merged commit 43d63a8 into BlueBrain:master Mar 25, 2024
6 checks passed
@wvangeit wvangeit deleted the fix_tests branch March 25, 2024 08:55
@anilbey
Copy link
Contributor

anilbey commented Mar 25, 2024

and py3.12 became a required action to merge to the master branch ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants