This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
Fixes for multi-execution in-memory transfer with NEURON #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- global ion maps were deleted at the end of every run
- in case of in-memory execution mechanisms are registered
only once and hence ions map is created only one
- this is why ions shouldnt not be deleted if we are doing
embedded run with neuron
nrnhines
approved these changes
Jul 27, 2020
iomaganaris
approved these changes
Jul 28, 2020
|
I will go ahead with merge now! |
pramodk
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
…oreNeuron#349) - global ion maps were deleted at the end of every run - in case of in-memory execution mechanisms are registered only once and hence ions map is created only one - this is why ions shouldnt not be deleted if we are doing embedded run with neuron CoreNEURON Repo SHA: BlueBrain/CoreNeuron@8ac2d6f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only once and hence ions map is created only one
embedded run with neuron
@cattabiani : this will also fix the issue where you were seeing segfault with
40%of mod files from v5 circuit.