-
Notifications
You must be signed in to change notification settings - Fork 41
Conversation
pramodk
commented
Aug 18, 2020
- add svclmp.mod mod file from NEURON
- update registeration callbacks
- expose at_time in the header file
- add svclmp.mod mod file from NEURON - update registeration callbacks - expose at_time in the header file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seem basically sound. I.e at_time already has an implementation. Also after_cvode
likely emits the correct code (just puts the call to the function in the nrn_solve function) and if not I can activate the proper code in mod2c.
NMODL needs to handle
|
please retest |
Given the recent work done by @iomaganaris on at_time, I think this PR can be merged too right? |
Yes but nmodl submodule needs to be updated in coreneuron repo. |
I don't remember how to expose "annotate" function for ISPC but @ohm314 or @iomaganaris might remember better. |
Thanks @iomaganaris for all fixes with ISPC! |
* Add SEClamp support in CoreNEURON - add svclmp.mod mod file from NEURON - update registeration callbacks - expose at_time in the header file * Fixed compilation issue for GPU with at_time and updated NMODL commit * Added definition of at_time in nrnoc_ml.ispc * Small fix for at_time declaration outside ispc Co-authored-by: Ioannis Magkanaris <iomagkanaris@gmail.com> CoreNEURON Repo SHA: BlueBrain/CoreNeuron@483f9d9