This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
Add support for inserting nmodl flags in nrnivmodl-core calls #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, this enables the call: nrnivmodl-core -a "sympy --analytic" mod/
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
iomaganaris
reviewed
Oct 8, 2020
Implementing the logic to sanitize the merge of default and runtime nmodl flags was a little too much for a makefile. We let the user add the runtime option at his own risk. We inform him on what were the default flags to let him make an easy merge with what he wants. - Add warning and info to be explicit
|
please retest |
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
…ain/CoreNeuron#398) * Add support for inserting nmodl flags in nrnivmodl-core calls For example, this enables the call: nrnivmodl-core -a "sympy --analytic" mod/ * Runtime nmodl flags replace build nmodl flags CoreNEURON Repo SHA: BlueBrain/CoreNeuron@a3797b9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, this enables the call:
nrnivmodl-core -a "sympy --analytic" mod/Partially addresses issue #344