This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
clang-format after moving to c++ #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pramodk
commented
Jun 5, 2018
pramodk
commented
- previous PR from Jeremy didn't update source style
- disable indentation of namespaces
- upgrade clang-format to 5.0
- previous PR from Jeremy didn't update source style - disable indentation of namespaces
fouriaux
reviewed
Jun 5, 2018
CMakeLists.txt
Outdated
| @@ -163,8 +163,8 @@ add_definitions(-DCORENEURON_BUILD) | |||
| option (ENABLE_SELECTIVE_GPU_PROFILING "Enable GPU profiling only for Solver" ON) | |||
| option (ENABLE_OPENACC "Enable use of OpenACC" OFF) | |||
|
|
|||
| set(CLANG_FORMAT_MIN_VERSION "4.0") | |||
| set(CLANG_FORMAT_MAX_VERSION "4.9") | |||
| set(CLANG_FORMAT_MIN_VERSION "5.0") | |||
There was a problem hiding this comment.
Does changing CLANG_FORMAT_MIN version is changing some formating or correcting C++ formating ?
There was a problem hiding this comment.
obviously this is typo...I wanted to set min to 5.0 and max to 5.9.
fouriaux
reviewed
Jun 5, 2018
no specific reason but 4.0 is quite old now and when we install clang-format (say with brew), clang-format 5 is installed. Hence I thought we should start using latest version. |
|
p.s. note that most of changes in this PR are not specific to 5.0 |
pramodk
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
- previous PR from Jeremy didn't update source style - disable indentation of namespaces CoreNEURON Repo SHA: BlueBrain/CoreNeuron@b21da2f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.