Fix: Raise a clear error when there is no tree of given type

neurots/extract_input/from_TMD.py

@@ -17,6 +17,8 @@
 
 import tmd
 
+from neurots.utils import NeuroTSError
+
 
 def persistent_homology_angles(
     pop, threshold=2, neurite_type="basal_dendrite", feature="radial_distances"
@@ -35,12 +37,14 @@ def persistent_homology_angles(
     ph_ang = [
         tmd.methods.get_ph_angles(tree, feature=feature) for tree in getattr(pop, neurite_type)
     ]
+    if not ph_ang:
+        raise NeuroTSError(f"The given population does contain any tree of {neurite_type} type.")
 
     # Keep only the trees whose number of terminations is above the threshold
     # Saves the list of persistence diagrams for the selected neurite_type
     phs = [p for p in ph_ang if len(p) > threshold]
     if not phs:
-        raise ValueError(
+        raise NeuroTSError(
             "The given threshold excluded all bars of the persistence diagram, please use a "
             "lower threshold value."
         )

tests/test_extract_input.py

@@ -307,7 +307,7 @@ def test_path_distances(self, filename):
 
     def test_threshold_too_small(self):
         with pytest.raises(
-            ValueError,
+            NeuroTSError,
             match=(
                 "The given threshold excluded all bars of the persistence diagram, please use a "
                 "lower threshold value."
@@ -319,6 +319,14 @@ def test_threshold_too_small(self):
                 neurite_types=["basal_dendrite"],
             )
 
+    def test_missing_neurite_type(self):
+        with pytest.raises(NeuroTSError):
+            extract_input.distributions(
+                os.path.join(_PATH, "diam_simple.swc"),
+                feature="path_distances",
+                neurite_types=["basal_dendrite", "apical_dendrite"],
+            )
+
     def test_trunk_length(self, filename):
         distr = extract_input.distributions(filename, feature="trunk_length")
         assert "persistence_diagram" not in distr["basal_dendrite"]